-
Notifications
You must be signed in to change notification settings - Fork 482
Prepare images for Postgres 12 / PostGIS 3.0.0 #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Initially I wanted only to add a new 12 + 3.0 image, but other images refused to build with the old 2.5 version and updating to a newer 2.5 version was bringing issues with |
Great to see people work on it already! Please note that without GEOS 3.8+ there is relatively little point in upgrading to PostGIS 3.0. See https://carto.com/blog/postgis-3-release/ |
Works fine so far with importing and rendring volga_fed_districts OSM extract using OpenMapTiles stack (using Debian 12-3 image). |
Beware! I was setting up Nominatim and encountered this PG12 bug, a fix for which not been merged yet: https://www.postgresql.org/message-id/flat/20191004043021.ylfbxcjqyypphfft%40alap3.anarazel.de#c11dfd761fe0bdf9fc48436cc69aff62 |
@eyusupov older GEOS will work, it just won't work as fast. Also note that you may want to disable PostgreSQL JIT -- it has a bug when running complex queries, making them run 1000x times slower. See https://www.postgresql.org/message-id/20191025010456.ubs2jdxdrb6td7m2%40alap3.anarazel.de |
Not working for me.
getting this error
P.S. - Alpine worked fine |
Another thing to be aware of -- there is a bug in PostGIS 3.0, making holes dissappear in complex geometries (e.g. natural earth's water polygons 50m would show up without New Zealand and a few other places). This issue has been fixed in PostGIS master. |
Results from my testing: Windows 10
docker-postgis\12-3\alpine
For alpine the build of the image is ok, but it fails on run (see two last loglines) Thought this might had something to do with unix/windows file-endings. Tried therefore changing the line endings on the "postgis.sh" file from CRLF to LF, which resulted in I then changed to initdb-postgis.sh to this: (which works)
|
@torangel I don't have a windows machine to reproduce. Are you getting successful build on the master branch? |
1- Confirmation@eyusupov . Obviously the 12-3 does not exist in the master branch (if I understood your question correct), but I can confirm the same problem relies in the master branch as well for the
2-Failing alpine (because of packages?`)I have now done another try on building the 12-3 alpine image, but what previously worked just fine now failes with the following errormessage:
I notice that the build-deps-edge is I am not deeply into the APK and gdal, but it looks to me as if something has changed in the package repository? Any advice on how to handle this is greatly appreciated. Additional informationWhen running apk add without the --virtual switch:
|
I work with changing value: https://apt.postgresql.org/pub/repos/apt/pool/main/p/postgis/ |
Updated debian package version and rebased it on latest master |
I can confirm @eyusupov 's change now is building succesfully on 12-3/alpine however still fails with the message:
I cannot find the gdal package in the edge/testing repo. I however can find it in When trying using this repo the build continues, but fails on |
Replaced testing repo with community and added |
Adding gcc or clang package did not help, will investigate further |
Postgres 12 image build fails with:
|
Hey guys! I'm in testing and trying to get a world building server running as quickly as possible. Still trying to figure everything out though. I am currently using a modified version below of eyusupov/postgis-osm running the latest version of everything. Noticed you're also working on a Alpine version. Is there a significant difference between the two? I finally got pg12 running quickly with the git=off suggestion, so thanks for that. Are there any other openmaptiles pieces that are being worked on for speed? Thanks!
|
@eyusupov I think we wait to build new docker images includes This PR for alpine. The current postgres image build with alpine v3.10 and llvm8 but the I built postgres image as |
I tried building from But was faced with this error/log
Something obvious I am doing wrong? |
@torangel |
- remove streath and add buster to support current postgres images - run update.sh again
@eyusupov I finished my work for your PR.
|
- fixes: MAINTENER is duprecated
Also I fixes bug in postgres2.4-postgis2.5 now. |
supports alpine v3.11 in postgres 12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a minor nit, and it needs a master merge/rebase, but looks good otherwise
- VERSION=9.6-3 | ||
- VERSION=9.6-3 VARIANT=alpine | ||
- VERSION=9.5-3 | ||
- VERSION=9.5-3 VARIANT=alpine | ||
- VERSION=9.4-2.5 | ||
- VERSION=9.4-2.5 VARIANT=alpine | ||
- VERSION=12-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit - should probably sort versions?
I think we no longer need this PR since master branch now has postgis 2.5 and 3.0 building on postgresql 9.5 through 12. We should close this PR and open issues and pull requests against the updated code on the master branch. Thanks for helping with this! |
This is based on #142.
proj is built with g++ and libstdc++ from edge, so the same version need
to be installed for it to work.
It compiles and runs, but I didn't test it thoroughly yet.
I'm going to try importing an OSM extract to test it.